Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Hermes 1.7.0 #3639

Merged
merged 12 commits into from
Oct 20, 2023
Merged

Release Hermes 1.7.0 #3639

merged 12 commits into from
Oct 20, 2023

Conversation

romac
Copy link
Member

@romac romac commented Sep 26, 2023

Closes: #XXX

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested review from seanchen1991 and ljoss17 and removed request for seanchen1991 October 20, 2023 14:44
@romac romac marked this pull request as ready for review October 20, 2023 14:44
seanchen1991
seanchen1991 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@seanchen1991 seanchen1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits; looks good otherwise!

.changelog/v1.7.0/summary.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
guide/src/templates/hermes-version.md Show resolved Hide resolved
@romac @seanchen1991
Apply suggestions from code review
9426cea 
Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Signed-off-by: Romain Ruetschi <github@romac.me>
@romac romac merged commit ac916f5 into master Oct 20, 2023
42 checks passed
@romac romac deleted the release/v1.7.0 branch October 20, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanchen1991 seanchen1991 seanchen1991 approved these changes

@ljoss17 ljoss17 ljoss17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romac @seanchen1991 @ljoss17